Skip to content

rule protobuf.cpp add custom args, pass through to protoc. Resolves #6398#6405

Merged
waruqi merged 3 commits intoxmake-io:devfrom
jiangyanan224:pb_rule
May 8, 2025
Merged

rule protobuf.cpp add custom args, pass through to protoc. Resolves #6398#6405
waruqi merged 3 commits intoxmake-io:devfrom
jiangyanan224:pb_rule

Conversation

@jiangyanan224
Copy link

@jiangyanan224 jiangyanan224 commented May 8, 2025

No description provided.

@jiangyanan224 jiangyanan224 requested a review from waruqi May 8, 2025 06:08
@star-hengxing
Copy link
Contributor

@waruqi 但凡要传给 rule 额外 flags 的,所有文件都应用的 flag 用 add_values ,然后再处理 fileconfig?


这里 commit 不应该用中文。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


@waruqi Anyone who wants to pass extra flags to rule, use add_values ​​for all files to apply flags, and then process fileconfig?


Commit should not be in Chinese here.

@waruqi
Copy link
Member

waruqi commented May 8, 2025

@waruqi 但凡要传给 rule 额外 flags 的,所有文件都应用的 flag 用 add_values ,然后再处理 fileconfig?

也可以,走 add_values 会方便点,可以同时支持

@waruqi
Copy link
Member

waruqi commented May 8, 2025

@jiangyanan224 中文 commit 去掉,改用英文,然后重新 force push 下

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


@waruqi Anyone who wants to pass extra flags to rule, use add_values ​​for all files to apply flags, and then process fileconfig?

It's OK, it will be more convenient to go to add_values ​​and can support it at the same time.

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


@jiangyanan224 Chinese commit Remove it, use English instead, and then force push again

@jiangyanan224
Copy link
Author

@jiangyanan224 中文 commit 去掉,改用英文,然后重新 force push 下

好的,已修改

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


@jiangyanan224 Chinese commit Remove it, use English instead, and then force push down again

OK, modified

@waruqi waruqi merged commit a3df7af into xmake-io:dev May 8, 2025
22 checks passed
@waruqi waruqi added this to the v3.0.0 milestone May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants