cargo: fix package cross-compilation#6402
Merged
waruqi merged 5 commits intoxmake-io:devfrom May 8, 2025
Merged
Conversation
waruqi
reviewed
May 8, 2025
waruqi
reviewed
May 8, 2025
xmake/toolchains/rust/xmake.lua
Outdated
| end | ||
|
|
||
|
|
||
| local target = import("private.tools.rust.target_triple")(toolchain:plat(), toolchain:arch(), opt) |
waruqi
reviewed
May 8, 2025
xmake/toolchains/rust/xmake.lua
Outdated
|
|
||
| local target = target_triple(toolchain:plat(), toolchain:arch(), opt) | ||
| if target then | ||
| toolchain:add("rcflags", "--verbose") |
Member
There was a problem hiding this comment.
why? if we want to get verbose info, we should use option.get("verbose") and option.get("diagnosis")
Member
Author
There was a problem hiding this comment.
It's a leftover, I'm removing it
Member
|
It will generate incorrect arch. #6574 on macOS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes cross-compilation with Cargo by passing the proper triple automatically
Also, the /host folder has to be passed to rustc to find some library (tested with naga)
Fixes xmake-io/xmake-repo#7023