Skip to content

(generators) cmake : fix compiler detection if (Gcc) with a more stan…#6386

Merged
waruqi merged 1 commit intoxmake-io:devfrom
PierreEVEN:fix-cmake_generator-compiler_names
May 3, 2025
Merged

(generators) cmake : fix compiler detection if (Gcc) with a more stan…#6386
waruqi merged 1 commit intoxmake-io:devfrom
PierreEVEN:fix-cmake_generator-compiler_names

Conversation

@PierreEVEN
Copy link
Contributor

@PierreEVEN PierreEVEN commented May 3, 2025

The cmake generator was not using the standard syntax to detect compiler

if (Gcc)
if (MSVC)
if (Clang)

to

if (CMAKE_COMPILER_ID STREQUAL "GNU")
if (CMAKE_COMPILER_ID STREQUAL "MSVC")
if (CMAKE_COMPILER_ID STREQUAL "Clang")

@waruqi waruqi added this to the v3.0.0 milestone May 3, 2025
@waruqi waruqi merged commit 6944b11 into xmake-io:dev May 3, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants