Skip to content

(cmake, llvm toolchain) when using --toolchain=llvm on windows, dependencies should be build with it#6381

Merged
waruqi merged 1 commit intoxmake-io:devfrom
Arthapz:fix-llvm-cmake-windows
May 6, 2025
Merged

(cmake, llvm toolchain) when using --toolchain=llvm on windows, dependencies should be build with it#6381
waruqi merged 1 commit intoxmake-io:devfrom
Arthapz:fix-llvm-cmake-windows

Conversation

@Arthapz
Copy link
Member

@Arthapz Arthapz commented May 1, 2025

No description provided.

@Arthapz Arthapz changed the title (cmake) when using --toolchain=llvm on windows, dependencies should b… (cmake, llvm toolchain, windows) when using --toolchain=llvm on windows, dependencies should b… May 1, 2025
@Arthapz Arthapz changed the title (cmake, llvm toolchain, windows) when using --toolchain=llvm on windows, dependencies should b… (cmake, llvm toolchain) when using --toolchain=llvm on windows, dependencies should be build with it May 1, 2025
@Doekin
Copy link
Contributor

Doekin commented May 1, 2025

With this change, building CMake packages using --toolchain=llvm successfully uses clang instead of MSBuild. Thanks for addressing this!

However, installing package fails with the following error:

finding libogg from xmake ..
checking for xmake::libogg ... libogg v1.3.5
{
  version = "v1.3.5",
  static = true,
  sysincludedirs = {
    "C:\Users\leemu\AppData\Local\.xmake\packages\l\libogg\v1.3.5\0df42afefcc14ed29c81a7b0567b9dec\include"
  }
}

error: @programdir\core\package\package.lua:2524: package(libogg): links not found!

In the installdir.failed directory, I found lib/libogg.a. It seems the check might not account for lib<xxx>.a on Windows.

@Arthapz
Copy link
Member Author

Arthapz commented May 1, 2025

With this change, building CMake packages using --toolchain=llvm successfully uses clang instead of MSBuild. Thanks for addressing this!

However, installing package fails with the following error:

finding libogg from xmake ..
checking for xmake::libogg ... libogg v1.3.5
{
  version = "v1.3.5",
  static = true,
  sysincludedirs = {
    "C:\Users\leemu\AppData\Local\.xmake\packages\l\libogg\v1.3.5\0df42afefcc14ed29c81a7b0567b9dec\include"
  }
}

error: @programdir\core\package\package.lua:2524: package(libogg): links not found!

In the installdir.failed directory, I found lib/libogg.a. It seems the check might not account for lib<xxx>.a on Windows.

oups wrong PR i wanted your insight here :D but it's nice this one is usefull to you and thanks for the review

@Arthapz Arthapz marked this pull request as draft May 1, 2025 15:55
@Arthapz Arthapz force-pushed the fix-llvm-cmake-windows branch from ebc11a7 to 255102b Compare May 5, 2025 18:30
@Arthapz Arthapz marked this pull request as ready for review May 5, 2025 18:31
@waruqi waruqi merged commit a4d1b8c into xmake-io:dev May 6, 2025
22 checks passed
@waruqi waruqi added this to the v3.0.0 milestone May 6, 2025
@Arthapz Arthapz deleted the fix-llvm-cmake-windows branch September 18, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants