package(autoconf): De-duplicate LDFLAGS#6321
Merged
waruqi merged 1 commit intoxmake-io:devfrom Apr 14, 2025
Merged
Conversation
waruqi
reviewed
Apr 14, 2025
| if ldflags or shflags then | ||
| -- autoconf does not use SHFLAGS | ||
| envs.LDFLAGS = table.concat(_translate_paths(table.join(ldflags or {}, shflags)), ' ') | ||
| envs.LDFLAGS = table.concat(table.unique(_translate_paths(table.join(ldflags or {}, shflags))), ' ') |
Member
There was a problem hiding this comment.
use reverse_unique to reserve link flags orders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to eliminate duplicate linker flags that appear after merging
ldflagsandshflags. This adjustment resolves the issue whereicu4cfails to build for Android inGit Bashon Windows due to redundant flags.