Improve MIDL support by lakor64 · Pull Request #6301 · xmake-io/xmake

lakor64 · 2025-04-08T13:37:53Z

Relative issue: #5926

Hello, this is my first time sending a PR so I hope I did everything correctly, the following PR extends the current existing MIDL support by adding the following functionalities:

Server and Client stub generation (/client and /server)
Proxy generation and compilation (_p)
Handling of warnings (/W0../W4)
Handling of target inclusions, definitions and undefinitions (/I, /D, /U)
Ability to define whenever to enable proxy, server or client generation as well as extra defs/undefs/incs

Some test projects are also added inside the folder tests/project/idl to verify the functionality.

Extra notes:

When I tried to build with "xmake" the file, it always runned the .idl compilation, which slows up a lot of compilation when you have multiple idl files, I tried to use the depend.on_changed there but I'm not sure if it's the correct way.
MIDL doesn't have a switch or message to 100% detect if an interface, proxy, client or server file will be generated, therefore I had to detect during build time if the C fiels were generated, and as there is no way that I know on xmake to detect if a file was generated on before_buildcmd_file because it invokes the binary multiple times (eg. a cleanup I wasn't able to do this corretly) so I moved the detect and compilation on the on_buildcmd_file, I hope this is ok
target:get("xxxxx") does not seem to get the public includes for some reason? or I misunderstood what the target: does?

xmake/rules/platform/windows/idl/xmake.lua

tests/projects/idl/test_rpc_noserver/xmake.lua

tests/projects/idl/test_norpc_proxy/src/lockowner.idl

xmake/rules/platform/windows/idl/xmake.lua

waruqi · 2025-04-09T05:47:13Z

please rebase to dev

xmake/rules/platform/windows/idl/xmake.lua

tests/projects/idl/test_rpc/src/test_iid.c

tests/projects/idl/test_rpc_noserver/src/test_iid.c

tests/projects/idl/test_norpc/src/test_iid.c

tests/projects/idl/test_norpc_proxy/src/test_iid.c

tests/projects/idl/test_rpc/src/test_iid.c

tests/projects/idl/test_rpc_noserver/src/test_iid.c

xmake/rules/platform/windows/idl/idl.lua

star-hengxing · 2025-04-24T08:44:14Z

local enable_server = true
local enable_client = true

-- add_files("*.idl", {client = true, server = false, proxy = false})
-- server will always true, use `fileconfig.server ~= nil`?
if fileconfig.server then
    enable_server = fileconfig.server
end

star-hengxing · 2025-04-24T08:45:59Z

xmake/rules/platform/windows/idl/idl.lua

+    local autogendir = path.join(target:autogendir(), "platform/windows/idl")
+
+    local enable_server = true
+    local enable_client = true


star-hengxing · 2025-04-24T08:46:15Z

xmake/rules/platform/windows/idl/idl.lua

+            local ccjob = target:fullname() .. "/obj/" .. sourcefile
+            jobgraph:add(ccjob, function (index, total, opt)
+                local fileconfig = target:fileconfig(sourcefile)
+                local enable_proxy = true


waruqi · 2025-04-24T15:04:10Z

local enable_server = true
local enable_client = true

-- add_files("*.idl", {client = true, server = false, proxy = false})
-- server will always true, use `fileconfig.server ~= nil`?
if fileconfig.server then
    enable_server = fileconfig.server
end

可以提个 pr 过来

lakor64 added 2 commits April 8, 2025 15:28

Add some midl tests

344d287

Improve midl support

cb97438

waruqi reviewed Apr 8, 2025

View reviewed changes

xmake/rules/platform/windows/idl/xmake.lua Outdated Show resolved Hide resolved

waruqi reviewed Apr 8, 2025

View reviewed changes

xmake/rules/platform/windows/idl/xmake.lua Outdated Show resolved Hide resolved

waruqi reviewed Apr 8, 2025

View reviewed changes

xmake/rules/platform/windows/idl/xmake.lua Outdated Show resolved Hide resolved

waruqi reviewed Apr 8, 2025

View reviewed changes

xmake/rules/platform/windows/idl/xmake.lua Outdated Show resolved Hide resolved

waruqi reviewed Apr 8, 2025

View reviewed changes

tests/projects/idl/test_rpc_noserver/xmake.lua Outdated Show resolved Hide resolved

waruqi reviewed Apr 8, 2025

View reviewed changes

tests/projects/idl/test_norpc_proxy/src/lockowner.idl Outdated Show resolved Hide resolved

waruqi reviewed Apr 8, 2025

View reviewed changes

xmake/rules/platform/windows/idl/xmake.lua Show resolved Hide resolved

waruqi requested a review from star-hengxing April 8, 2025 14:37

Address reviews

2051c13

waruqi reviewed Apr 9, 2025

View reviewed changes

xmake/rules/platform/windows/idl/xmake.lua Outdated Show resolved Hide resolved

Merge branch 'dev' of https://github.com/xmake-io/xmake into dev

7872391

waruqi reviewed Apr 10, 2025

View reviewed changes

xmake/rules/platform/windows/idl/xmake.lua Outdated Show resolved Hide resolved

waruqi reviewed Apr 10, 2025

View reviewed changes

xmake/rules/platform/windows/idl/xmake.lua Outdated Show resolved Hide resolved

waruqi reviewed Apr 10, 2025

View reviewed changes

xmake/rules/platform/windows/idl/xmake.lua Outdated Show resolved Hide resolved

waruqi reviewed Apr 10, 2025

View reviewed changes

xmake/rules/platform/windows/idl/xmake.lua Outdated Show resolved Hide resolved

waruqi reviewed Apr 10, 2025

View reviewed changes

xmake/rules/platform/windows/idl/xmake.lua Outdated Show resolved Hide resolved

waruqi reviewed Apr 10, 2025

View reviewed changes

tests/projects/idl/test_rpc/src/test_iid.c Outdated Show resolved Hide resolved

waruqi reviewed Apr 10, 2025

View reviewed changes

tests/projects/idl/test_rpc/src/test_iid.c Outdated Show resolved Hide resolved

waruqi reviewed Apr 10, 2025

View reviewed changes

tests/projects/idl/test_rpc_noserver/src/test_iid.c Outdated Show resolved Hide resolved

Format files

e865a02

lakor64 force-pushed the dev branch from 1700cd6 to e865a02 Compare April 15, 2025 09:38

lakor64 added 2 commits April 15, 2025 11:39

Merge branch 'dev' of https://github.com/xmake-io/xmake into dev

d6e9574

Use jobgraph rather than batchcmds

228a137

lakor64 requested a review from waruqi April 15, 2025 09:43

waruqi reviewed Apr 15, 2025

View reviewed changes

tests/projects/idl/test_norpc/src/test_iid.c Outdated Show resolved Hide resolved

waruqi reviewed Apr 15, 2025

View reviewed changes

tests/projects/idl/test_norpc_proxy/src/test_iid.c Outdated Show resolved Hide resolved

waruqi reviewed Apr 15, 2025

View reviewed changes

tests/projects/idl/test_rpc/src/test_iid.c Outdated Show resolved Hide resolved

waruqi reviewed Apr 15, 2025

View reviewed changes

tests/projects/idl/test_rpc_noserver/src/test_iid.c Outdated Show resolved Hide resolved

waruqi reviewed Apr 15, 2025

View reviewed changes

xmake/rules/platform/windows/idl/idl.lua Show resolved Hide resolved

waruqi reviewed Apr 15, 2025

View reviewed changes

xmake/rules/platform/windows/idl/idl.lua Show resolved Hide resolved

waruqi reviewed Apr 15, 2025

View reviewed changes

xmake/rules/platform/windows/idl/idl.lua Outdated Show resolved Hide resolved

waruqi reviewed Apr 15, 2025

View reviewed changes

xmake/rules/platform/windows/idl/idl.lua Outdated Show resolved Hide resolved

lakor64 added 5 commits April 15, 2025 15:40

Address formatting

d9d3b81

Merge branch 'dev' of https://github.com/xmake-io/xmake into dev

c3d9be2

Use jobgraph rather than batchcmd

42371b9

Merge branch 'dev' of https://github.com/xmake-io/xmake into dev

85eab26

Use jobgraphs

70c1944

lakor64 requested a review from waruqi April 22, 2025 08:59

waruqi added this to the v3.0.0 milestone Apr 22, 2025

waruqi added 2 commits April 22, 2025 17:35

Update idl.lua

a0d0742

Update xmake.lua

700b549

waruqi merged commit aeaeda4 into xmake-io:dev Apr 22, 2025
22 checks passed

waruqi mentioned this pull request Apr 22, 2025

xmake能否能支持IDL文件，MSRPC编程 #5926

Closed

star-hengxing reviewed Apr 24, 2025

View reviewed changes

star-hengxing mentioned this pull request May 6, 2025

Improve idl rule #6395

Merged

Uh oh!

Conversation

lakor64 commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waruqi commented Apr 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

star-hengxing commented Apr 24, 2025

Uh oh!

star-hengxing Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

star-hengxing Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

waruqi commented Apr 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lakor64 commented Apr 8, 2025 •

edited

Loading