[fix] xmake install skips SO with version like libfreetype.so.6.20.2#6257
Merged
waruqi merged 2 commits intoxmake-io:devfrom Mar 27, 2025
19317362:dev
Merged
[fix] xmake install skips SO with version like libfreetype.so.6.20.2#6257waruqi merged 2 commits intoxmake-io:devfrom 19317362:dev
waruqi merged 2 commits intoxmake-io:devfrom
19317362:dev
Conversation
waruqi
reviewed
Mar 27, 2025
| if line:startswith("NEEDED") then | ||
| local filename = line:split("%s+")[2] | ||
| if filename and filename:endswith(".so") then | ||
| if filename and filename:endswith(".so") or filename:match(".-%.so%.%d+") then |
Member
There was a problem hiding this comment.
I think we should use filename:find("%.so%.%d+$") instead of filename:match(".-%.so%.%d+")
Contributor
Author
There was a problem hiding this comment.
The code was generated by AI.
filename:find("%.so%.%d+$") works also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6253