feat: improve GN tool to support extra arguments#6149
Merged
waruqi merged 2 commits intoxmake-io:devfrom Feb 13, 2025
Merged
Conversation
Allows to pass extra arguments to ninja command. It defaults to an empty table (no arguments) for backward compatibility.
waruqi
reviewed
Feb 12, 2025
- rename option from argv to target, follows usage of ninja. - add option in install command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package.tools.gnAllows to pass extra arguments to ninja command. It defaults to an empty table (no arguments).
Example of usage:
This is a solution to discussion: #6148 (comment)
I've been able to test with my local installation of xmake. fyi, it allows to reduce time to build V8 in half.
Let me know if something is wrong or need changes.