Improve targetname input checks#6142
Merged
waruqi merged 11 commits intoxmake-io:devfrom Feb 11, 2025
Merged
Conversation
Add cost options and optimization
waruqi
reviewed
Feb 10, 2025
waruqi
reviewed
Feb 10, 2025
Remove explicit defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the help/error message for invalid targets from action run to more actions/plugins, makes it generally available and improves on it.
I replaced existing checks and added checks to actions that would try to access a nil target when given an invalid input targetname.
The levenshtein function now also takes options for costs which the
find_similar_targetnamesfunction makes use of.Currently this is only applied to actions/plugins but could also be used for e.g. xpack.
I'm unsure where to put the new files or if the current location is appropriate.