-
Notifications
You must be signed in to change notification settings - Fork 734
Open
Description
When including Opus as a git submodule, tags don't seem to be part of the data fetched by git. Therefore the logic applied here
opus/cmake/OpusPackageVersion.cmake
Lines 10 to 12 in 12a356e
| execute_process(COMMAND ${GIT_EXECUTABLE} | |
| --git-dir=${CMAKE_CURRENT_LIST_DIR}/.git describe | |
| --tags --match "v*" OUTPUT_VARIABLE OPUS_PACKAGE_VERSION) |
doesn't work out and retrieving the version will fail.
Why are tags used in that way anyway? Wouldn't it be easier if the version was simply specified in the CMakeLists.txt? Then it wouldn't be necessary to include a dedicated version file in the released source trees either 👀
Metadata
Metadata
Assignees
Labels
No labels