Switch to slicing-by-8 CRC32 algorithm#37
Merged
1 commit merged intoMay 21, 2018
Merged
Conversation
|
LGTM, thanks! I think we can live with the extra 7.75KiB table space, so no need to make it configurable. I'll take a bit to review the docs you linked before merging. |
Contributor
Author
|
Great! Thanks for having a look at it! The |
Contributor
Author
|
@tdaede Any news on this one? |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
This PR replaces the single look-up-table CRC32 implementation with the slicing-by-8 algorithm. The new algorithm is approximately 5 times faster than single table lookup CRC.
This improves Ogg FLAC encoding speed by about 5% and decoding by 10%. Other codecs benefit too. Opus decoding is roughly 1%, Vorbis decoding about 2% faster. Pure muxing of already encoded material will probably benefit the most, but I did not test this.
Switching to a slicing algorithm was proposed before by Rodney Brown, but the discussion came to nothing after raising questions about the patent situation. I did a patent search and found the last of the relevant patents on this algorithm having expired in December 2017.
See here for my original article on this and here for the discussion on HydrogenAudio.
It would be great to see this added to the official Ogg source.
Robert