Code review feedback

AndreSchumacher · AndreSchumacher · commit cbb579346a7b · 2014-06-19T18:03:42.000+03:00
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetConverter.scala b/sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetConverter.scala
@@ -449,9 +449,9 @@ private[parquet] class CatalystNativeArrayConverter(
     protected[parquet] var capacity: Int = CatalystArrayConverter.INITIAL_ARRAY_SIZE)
   extends GroupConverter with CatalystConverter {
 
-  type nativeType = elementType.JvmType
+  type NativeType = elementType.JvmType
 
-  private var buffer: CatalystConverter.ArrayScalaType[nativeType] =
+  private var buffer: CatalystConverter.ArrayScalaType[NativeType] =
     elementType.classTag.newArray(capacity)
 
   private var elements: Int = 0
@@ -475,43 +475,43 @@ private[parquet] class CatalystNativeArrayConverter(
   // Overriden here to avoid auto-boxing for primitive types
   override protected[parquet] def updateBoolean(fieldIndex: Int, value: Boolean): Unit = {
     checkGrowBuffer()
-    buffer(elements) = value.asInstanceOf[nativeType]
+    buffer(elements) = value.asInstanceOf[NativeType]
     elements += 1
   }
 
   override protected[parquet] def updateInt(fieldIndex: Int, value: Int): Unit = {
     checkGrowBuffer()
-    buffer(elements) = value.asInstanceOf[nativeType]
+    buffer(elements) = value.asInstanceOf[NativeType]
     elements += 1
   }
 
   override protected[parquet] def updateLong(fieldIndex: Int, value: Long): Unit = {
     checkGrowBuffer()
-    buffer(elements) = value.asInstanceOf[nativeType]
+    buffer(elements) = value.asInstanceOf[NativeType]
     elements += 1
   }
 
   override protected[parquet] def updateDouble(fieldIndex: Int, value: Double): Unit = {
     checkGrowBuffer()
-    buffer(elements) = value.asInstanceOf[nativeType]
+    buffer(elements) = value.asInstanceOf[NativeType]
     elements += 1
   }
 
   override protected[parquet] def updateFloat(fieldIndex: Int, value: Float): Unit = {
     checkGrowBuffer()
-    buffer(elements) = value.asInstanceOf[nativeType]
+    buffer(elements) = value.asInstanceOf[NativeType]
     elements += 1
   }
 
   override protected[parquet] def updateBinary(fieldIndex: Int, value: Binary): Unit = {
     checkGrowBuffer()
-    buffer(elements) = value.getBytes.asInstanceOf[nativeType]
+    buffer(elements) = value.getBytes.asInstanceOf[NativeType]
     elements += 1
   }
 
   override protected[parquet] def updateString(fieldIndex: Int, value: Binary): Unit = {
     checkGrowBuffer()
-    buffer(elements) = value.toStringUsingUTF8.asInstanceOf[nativeType]
+    buffer(elements) = value.toStringUsingUTF8.asInstanceOf[NativeType]
     elements += 1
   }
 
@@ -533,7 +533,7 @@ private[parquet] class CatalystNativeArrayConverter(
   private def checkGrowBuffer(): Unit = {
     if (elements >= capacity) {
       val newCapacity = 2 * capacity
-      val tmp: CatalystConverter.ArrayScalaType[nativeType] =
+      val tmp: CatalystConverter.ArrayScalaType[NativeType] =
         elementType.classTag.newArray(newCapacity)
       Array.copy(buffer, 0, tmp, 0, capacity)
       buffer = tmp
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetRelation.scala b/sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetRelation.scala
@@ -151,7 +151,7 @@ private[sql] object ParquetRelation {
     }
 
     if (fs.exists(path) &&
-      !fs.getFileStatus(path)
+        !fs.getFileStatus(path)
         .getPermission
         .getUserAction
         .implies(FsAction.READ_WRITE)) {
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableOperations.scala b/sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableOperations.scala
@@ -168,7 +168,7 @@ case class InsertIntoParquetTable(
 
     val writeSupport =
       if (child.output.map(_.dataType).forall(_.isPrimitive())) {
-        logger.info("Initializing MutableRowWriteSupport")
+        logger.debug("Initializing MutableRowWriteSupport")
         classOf[org.apache.spark.sql.parquet.MutableRowWriteSupport]
       } else {
         classOf[org.apache.spark.sql.parquet.RowWriteSupport]
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTypes.scala b/sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTypes.scala
@@ -176,7 +176,7 @@ private[parquet] object ParquetTypesConverter {
 
   /**
    * Converts a given Catalyst [[org.apache.spark.sql.catalyst.types.DataType]] into
-   * the corrponsing Parquet `Type`.
+   * the corresponding Parquet `Type`.
    *
    * The conversion follows the rules below:
    * <ul>

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ private[sql] object ParquetRelation {`
`151`	`151`	`}`
`152`	`152`
`153`	`153`	`if (fs.exists(path) &&`
`154`		`- !fs.getFileStatus(path)`
	`154`	`+ !fs.getFileStatus(path)`
`155`	`155`	`.getPermission`
`156`	`156`	`.getUserAction`
`157`	`157`	`.implies(FsAction.READ_WRITE)) {`
Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ private[parquet] object ParquetTypesConverter {`
`176`	`176`
`177`	`177`	`/**`
`178`	`178`	`* Converts a given Catalyst [[org.apache.spark.sql.catalyst.types.DataType]] into`
`179`		- * the corrponsing Parquet `Type`.
	`179`	+ * the corresponding Parquet `Type`.
`180`	`180`	`*`
`181`	`181`	`* The conversion follows the rules below:`
`182`	`182`	`* <ul>`