Improve connection retry error mapping #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the connection retry logic by making constraint violation and permission denied errors non-retriable. It also refactors the mapError function to MapError to make it publicly accessible for use in the retry logic.
- Adds logic to mark constraint violation and permission denied errors as non-retriable
- Exports the
mapErrorfunction asMapErrorfor use across packages - Adds comprehensive test coverage for the
isRetriableErrorfunction
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/postgres/errors.go | Exports mapError function as MapError |
| internal/postgres/retrier/pg_querier_retrier.go | Implements non-retriable error checks for permission denied and constraint violation errors |
| internal/postgres/retrier/pg_querier_retrier_test.go | Adds test cases for isRetriableError function covering various error types |
| internal/postgres/pg_utils.go | Updates function call from mapError to MapError |
| internal/postgres/pg_tx.go | Updates function calls from mapError to MapError |
| internal/postgres/pg_replication_conn.go | Updates function calls from mapError to MapError |
| internal/postgres/pg_conn_pool.go | Updates function calls from mapError to MapError |
| internal/postgres/pg_conn.go | Updates function calls from mapError to MapError |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
exekias
approved these changes
Nov 13, 2025
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the logic that determines if a connection error is retriable to not retry in the following cases:
Related Issue(s)
Type of Change
Testing