Xata db support #603
Merged
Xata db support #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3992850 to
9e42fed
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Xata databases by implementing role handling for Xata-managed roles and providing comprehensive onboarding documentation.
- Excludes Xata-managed roles (
xata,xata_superuser) and thepostgresrole from role snapshotting - Adds comprehensive Xata onboarding guide covering snapshots and replication workflows
- Updates test fixtures to reflect the exclusion of the
postgresrole
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pkg/snapshot/generator/postgres/schema/pgdumprestore/pg_role_parser.go |
Adds postgresRole constant, pgXataRoles map, and updates isExcludedRole() to exclude postgres and Xata-managed roles |
pkg/snapshot/generator/postgres/schema/pgdumprestore/test/test_dump_filtered.sql |
Updates test fixture to use test_role instead of postgres role, removes postgres ownership statements |
pkg/snapshot/generator/postgres/schema/pgdumprestore/test/test_dump.sql |
Updates test fixture to use test_role instead of postgres role |
docs/xata.md |
Adds comprehensive Xata onboarding guide with snapshot/replication setup instructions and troubleshooting |
docs/privileges.md |
Adds reference to new Xata onboarding guide |
README.md |
Adds Xata documentation link and removes extraneous blank lines |
Comments suppressed due to low confidence (1)
pkg/snapshot/generator/postgres/schema/pgdumprestore/pg_role_parser.go:1
- The
TestIsExcludedRoletest lacks coverage for the newly added Xata roles (xata,xata_superuser) and thepostgresrole exclusion. Add test cases forxata,xata_superuser, andpostgresto verify they are correctly excluded.
// SPDX-License-Identifier: Apache-2.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9e42fed to
d4a723e
Compare
exekias
approved these changes
Nov 13, 2025
d4a723e to
8699170
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds role handling for Xata databases. It also adds onboarding documentation.
Onboarding guide preview link.
Related Issue(s)
Type of Change
Changes Made
Testing