This repository was archived by the owner on May 1, 2024. It is now read-only.
[iOS] make button renderer constructor public#4313
Merged
Conversation
StephaneDelcroix
approved these changes
Nov 5, 2018
hartez
approved these changes
Nov 5, 2018
Contributor
|
Hola! I just wanted to update this with a screenshot and a question! This screenshot shows the ABI break that the original commit introduced: It was great that we caught this with the normal regression test-suite, but I'm wondering if we can add a tool to detect these breaks before PRs are merged. If you don't have such a tool and want one, I think monodevelop already has one that could be re-used :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Having a protected constructor on a renderer causes the previewer to break
Platforms Affected
PR Checklist