Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[Mac] Fixes crash after changing main page#4228

Merged
PureWeen merged 1 commit intoxamarin:3.3.0from
paymicro:fix-gh4156
Oct 27, 2018
Merged

[Mac] Fixes crash after changing main page#4228
PureWeen merged 1 commit intoxamarin:3.3.0from
paymicro:fix-gh4156

Conversation

@paymicro
Copy link
Copy Markdown
Contributor

Description of Change

When view is disposed, don't try to get the next or previous native view.

Issues Resolved

API Changes

None

Platforms Affected

  • MacOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

  • run ControlGallery on Mac
  • click on SwapRoot - MasterDetailPage
  • the application shouldn't crash

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@samhouts
Copy link
Copy Markdown
Contributor

build

@PureWeen PureWeen merged commit 7f32db3 into xamarin:3.3.0 Oct 27, 2018
@paymicro paymicro deleted the fix-gh4156 branch October 29, 2018 11:49
@samhouts samhouts added blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. i/critical i/regression labels Nov 2, 2018
@PureWeen PureWeen added this to the 3.3.0 milestone Nov 2, 2018
@itsTurk
Copy link
Copy Markdown

itsTurk commented Dec 27, 2018

Any ETA on this release?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. hacktoberfest 🍻 i/regression p/macOS t/bug 🐛

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants