Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[C] Add Default value to OnIdiom#4225

Merged
StephaneDelcroix merged 2 commits into3.4.0from
fix_4006
Nov 5, 2018
Merged

[C] Add Default value to OnIdiom#4225
StephaneDelcroix merged 2 commits into3.4.0from
fix_4006

Conversation

@StephaneDelcroix
Copy link
Copy Markdown
Member

@StephaneDelcroix StephaneDelcroix commented Oct 26, 2018

Description of Change

[C] Add Default value to OnIdiom

Issues Resolved

API Changes

Added:

  • public T OnIdiom<T>.Default {get; set;}

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@samhouts samhouts mentioned this pull request Oct 26, 2018
3 tasks
Copy link
Copy Markdown
Contributor

@kingces95 kingces95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a little test? Or extend an existing test?

@samhouts samhouts added the e/1 🕐 1 label Nov 2, 2018
@StephaneDelcroix StephaneDelcroix merged commit 885fa9a into 3.4.0 Nov 5, 2018
@StephaneDelcroix StephaneDelcroix deleted the fix_4006 branch November 5, 2018 13:13
@PureWeen PureWeen added this to the 3.4.0 milestone Nov 8, 2018
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a/Xaml </> e/1 🕐 1 in-progress This issue has an associated pull request that may resolve it! t/enhancement ➕

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants