This repository was archived by the owner on May 1, 2024. It is now read-only.
[Android] Enforce clipping on fast renderer ImageRenderer when using AspectFill#4218
Merged
[Android] Enforce clipping on fast renderer ImageRenderer when using AspectFill#4218
Conversation
kingces95
approved these changes
Oct 25, 2018
Contributor
kingces95
left a comment
There was a problem hiding this comment.
Yeah, man. This ain't kindergarten. No drawing outside the lines.
Contributor
|
build --uitests |
samhouts
approved these changes
Oct 25, 2018
This was referenced Dec 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The fix for Android's clipping issues (#3559) broke the fast ImageRenderer when using AspectFill, because the cropping caused by
setClipChildrenwas no longer in play.This change adds clipping to the boundaries of the
ImageViewwhen theScaleTypeis set toCENTER_CROP.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
See #4133 for 'before' screenshots.
After:
Testing Procedure
Open the Image Gallery in Control Gallery, select the AspectFill test. The image should look like it does in the "after" screenshot above.
PR Checklist