Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[Enhancement] Possibility to change IsPassword for MacOS#4175

Merged
rmarinho merged 3 commits intoxamarin:masterfrom
AndreiMisiukevich:fx_2223
Oct 25, 2018
Merged

[Enhancement] Possibility to change IsPassword for MacOS#4175
rmarinho merged 3 commits intoxamarin:masterfrom
AndreiMisiukevich:fx_2223

Conversation

@AndreiMisiukevich
Copy link
Copy Markdown
Contributor

@AndreiMisiukevich AndreiMisiukevich commented Oct 22, 2018

Description of Change

Issues Resolved

API Changes

Changed: EntryRenderer (Update control on IsPassword change)

Platforms Affected

  • MacOS

Behavioral/Visual Changes

You can change IsPassword for entry

Testing Procedure

Create entry and button. Change IsPassword of entry on button click. It should work

@AndreiMisiukevich AndreiMisiukevich changed the title [Enhancement] Issue 2223 (Possibility to change IsPassword for MacOS [Enhancement] Issue 2223 Possibility to change IsPassword for MacOS Oct 22, 2018
@rmarinho rmarinho self-requested a review October 22, 2018 16:38
@PureWeen PureWeen requested a review from samhouts October 22, 2018 17:24
@AndreiMisiukevich AndreiMisiukevich changed the title [Enhancement] Issue 2223 Possibility to change IsPassword for MacOS [Enhancement] Possibility to change IsPassword for MacOS Oct 23, 2018
@samhouts
Copy link
Copy Markdown
Contributor

build

Copy link
Copy Markdown
Contributor

@samhouts samhouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test page for this? Thanks!

@AndreiMisiukevich
Copy link
Copy Markdown
Contributor Author

@samhouts sure, just added it

@samhouts
Copy link
Copy Markdown
Contributor

build

@rmarinho rmarinho merged commit ef6414e into xamarin:master Oct 25, 2018
@samhouts samhouts added the e/6 🕕 6 label Nov 2, 2018
@samhouts samhouts added this to the 4.0.0 milestone Dec 4, 2018
@AndreiMisiukevich AndreiMisiukevich deleted the fx_2223 branch December 17, 2018 22:11
@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entry's IsPassword property , when changed programmatically is not masking/unmasking text in the screen in Mac app

4 participants