Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[UWP] Added margin inside scroll view#2515

Merged
jassmith merged 1 commit intoxamarin:masterfrom
paymicro:fix-gh2357-margin_in_scroll_view
May 3, 2018
Merged

[UWP] Added margin inside scroll view#2515
jassmith merged 1 commit intoxamarin:masterfrom
paymicro:fix-gh2357-margin_in_scroll_view

Conversation

@paymicro
Copy link
Copy Markdown
Contributor

@paymicro paymicro commented Apr 20, 2018 •
edited by samhouts
Loading

Description of Change

Added margins to view elements
http://prntscr.com/j7wqei

Bugs Fixed

Fixes #2357

API Changes

None

Behavioral Changes

All views in UWP now will process margin.
Also inside ScrollView.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@samhouts samhouts added the p/UWP label Apr 20, 2018
@rmarinho rmarinho requested review from jassmith and samhouts April 23, 2018 14:08
@rmarinho
Copy link
Copy Markdown
Member

rmarinho commented May 3, 2018

@paymicro can you add screenshots of without your fix and with your fix, also please add a Test case

@paymicro
Copy link
Copy Markdown
Contributor Author

paymicro commented May 3, 2018

without fix
http://recordit.co/86RDKs2Sl9

after fix
http://recordit.co/ccVXGKu8pJ

@jassmith jassmith merged commit c504478 into xamarin:master May 3, 2018
@paymicro paymicro deleted the fix-gh2357-margin_in_scroll_view branch May 4, 2018 11:07
This was referenced May 17, 2018
Closed
Merged
@samhouts samhouts added this to the 3.2.0 milestone Jun 26, 2018
@paymicro paymicro mentioned this pull request Aug 14, 2018
Merged
3 tasks
@samhouts samhouts modified the milestone: 3.2.0 Sep 12, 2018
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@samhouts samhouts Awaiting requested review from samhouts

2 more reviewers

@jassmith jassmith jassmith approved these changes

@rmarinho rmarinho rmarinho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Has two approvals, no pending reviews, and no changes requested p/UWP t/bug 🐛

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@paymicro @rmarinho @jassmith @samhouts