This repository was archived by the owner on May 1, 2024. It is now read-only.
[Android] DatePicker unfocuses on cancel#204
Merged
Conversation
|
|
||
| void OnCancelButtonClicked(object sender, EventArgs e) | ||
| { | ||
| Element.Unfocus(); |
Member
There was a problem hiding this comment.
Is Unfocus and ClearFocus the same?
Contributor
Author
There was a problem hiding this comment.
ClearFocus is on the Android View class and calling Element.Unfocus is keeping track of the fact that it's being dismissed/unfocused away since it apparently wasn't being updated by the cancel button which I suppose is treated differently than clicking Ok/Done or the equivalent.
Member
|
Needs rebase |
a68b586 to
5178156
Compare
Contributor
Author
|
Done |
Member
|
👍 |
1 similar comment
|
👍 |
The DatePicker in Android would remain focused when being closed via the cancel button, and a subsequent re-focus via something such as button would not function as expected.
5178156 to
b86d594
Compare
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
When using the DatePicker in Android, closing it via the cancel button would not unfocus the Element, causing a Focus() call via something such as a button to not function as otherwise expected.
Bugs Fixed
https://bugzilla.xamarin.com/show_bug.cgi?id=41424
API Changes
None
Behavioral Changes
None expected
PR Checklist