This repository was archived by the owner on Jan 10, 2025. It is now read-only.
[Touch.Server] Fix parsing of -address, -port and -logpath options#97
Merged
spouliot merged 3 commits intoxamarin:mainfrom Jan 8, 2021
rpendleton:fix-option-parsing
Merged
[Touch.Server] Fix parsing of -address, -port and -logpath options#97spouliot merged 3 commits intoxamarin:mainfrom rpendleton:fix-option-parsing
spouliot merged 3 commits intoxamarin:mainfrom
rpendleton:fix-option-parsing
Conversation
Contributor
Author
Co-authored-by: Sebastien Pouliot <sebastien.pouliot@gmail.com>
mandel-macaque
approved these changes
Jan 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the ip, port and logpath options were missing
=at the end of their names, you couldn't actually pass any values for them. If you tried, the string values for the options would be equal to their names (rather than what the user provided), and then the parsing failures for those strings would be silently ignored.Additionally, after the
IPAddresswas successfully parsed, we ignored the result. This resulted inlistener.Addressbeing null, which eventually led to a crash once the listener was started. I fixed this as well.In addition to adding the
=to each option, I also changed the parsing fromTryParsetoParseso that invalid option values will fail with an exception. This is similar to how theTimeSpanoptions are already being handled, but I wasn't sure if it would be considered a breaking change. I just figured it's better to let the user know something is wrong vs silently ignore invalid input from them, but I can revert that change if necessary.