Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Add more extensions for location#469

Merged
Redth merged 3 commits intomasterfrom
feature/extension-enhancements
Aug 13, 2018
Merged

Add more extensions for location#469
Redth merged 3 commits intomasterfrom
feature/extension-enhancements

Conversation

@jamesmontemagno
Copy link
Copy Markdown
Collaborator

@jamesmontemagno jamesmontemagno commented Aug 11, 2018

Description of Change

Describe your changes here.

Bugs Fixed

  • Related to issue #

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

List all API changes here (or just put None), example:

Added:

  • string - string Class.Property { get; set; }
  • void Class.Method();

Changed:

  • object Cell.OldPropertyName => object Cell.NewPropertyName

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno jamesmontemagno requested a review from Redth August 11, 2018 19:09
@dend
Copy link
Copy Markdown
Contributor

dend commented Aug 11, 2018

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/Types/Location.shared.cs ✅Succeeded
Xamarin.Essentials/Types/LocationExtensions.shared.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@dend
Copy link
Copy Markdown
Contributor

dend commented Aug 11, 2018

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/Types/Location.shared.cs ✅Succeeded
Xamarin.Essentials/Types/LocationExtensions.shared.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@dend
Copy link
Copy Markdown
Contributor

dend commented Aug 11, 2018

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/Types/Location.shared.cs ✅Succeeded
Xamarin.Essentials/Types/LocationExtensions.shared.cs ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml ✅Succeeded
docs/en/Xamarin.Essentials/Location.xml ✅Succeeded
docs/en/Xamarin.Essentials/LocationExtensions.xml ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Mrnikbobjeff
Copy link
Copy Markdown
Contributor

I started working on a variety of proposals open here, an I would love to see a strong type for distance, preferably with properties for km and miles. If we introduce the concept of a distance I would love to see it getting its own type. Would also be useful for geofencing

@jamesmontemagno
Copy link
Copy Markdown
Collaborator Author

We do have a distance type in there already of Miles or Kilometers. It is a simple enum ;)

@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label Aug 12, 2018
@jamesmontemagno jamesmontemagno added this to the 0.10.0-preview milestone Aug 12, 2018
@Redth Redth merged commit 946bd56 into master Aug 13, 2018
@Redth Redth deleted the feature/extension-enhancements branch August 13, 2018 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

awaiting-review This PR needs to have a set of eyes on it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants