This repository was archived by the owner on May 15, 2024. It is now read-only.
better UIColor conversion#1716
Merged
Redth merged 2 commits intoxamarin:mainfrom Jul 12, 2021
tipa:main
Merged
Conversation
jamesmontemagno
approved these changes
Mar 5, 2021
Collaborator
|
Anything for the other platforms at all? |
Contributor
Author
|
@jamesmontemagno Windows & Android are using bytes for their "platform colors" so the bytes from the "system color" can be used 1:1 |
Collaborator
|
Should also add some tests -> https://github.com/xamarin/Essentials/blob/main/Tests/Color_Tests.cs |
Contributor
Author
|
Just spent an hour trying to add tests but the solution wouldn't build on my VS4Mac and on Windows, VS kept freezing when trying to start a remote session or the iOS simulator wouldn't launch. This was the test I intended to try: |
Collaborator
|
@mattleibow good to go? |
Redth
approved these changes
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Better UIColor conversion uses rounding instead of cutting off decimals
Bugs Fixed
fixes #1572
API Changes
none
Behavioral Changes
none
PR Checklist
mainat time of PR