This repository was archived by the owner on May 15, 2024. It is now read-only.
[Android] [WebAuth] Rework authentication flow#1511
Merged
mattleibow merged 3 commits intomainfrom Nov 11, 2020
Merged
Conversation
- The 2FA process breaks the flow but opening a separate activity from a separate app. This results in the flow being interpreted as a cancellation. - The new flow uses an intermediate activity to correctly process the results. - Also converted the BindService into an async method. - Fixes #1292
mattleibow
commented
Nov 9, 2020
| if (activity != null) | ||
| CheckAppActions(activity.Intent); | ||
|
|
||
| WebAuthenticator.OnResume(null); |
Member
Author
There was a problem hiding this comment.
This i no longer used as the main activity neve has to handle the authentication events. This is now done by the intermediate activity.
Redth
previously approved these changes
Nov 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Rework the authentication flow to better support interruptions, either by the user or the actual process of authentication via 2FA.
The new flow makes use of 2 "intermediate" activities. The first one,
WebAuthenticatorIntermediateActivity, represents the container for the actual authentication process and starts the custom tabs. This will then handle the interruptions. The second one,WebAuthenticatorCallbackActivity, represents the "authenticated" path. This activity will then re-launch the first activity, but this time with different flags. These new flags will close the custom tabs and then complete the flow.Bugs Fixed
API Changes
None.
Behavioral Changes
None.
PR Checklist
mainat time of PR