Update Samples.iOS app to be compatible with App Store#1508
Update Samples.iOS app to be compatible with App Store#1508mattleibow merged 12 commits intoxamarin:mainfrom
Conversation
* required by App Store Connect
* App Store Connect complained: ERROR ITMS-90158: "The following URL schemes found in your app are not in the correct format: [appcenter-APP_SECRET]. URL schemes need to begin with an alphabetic character, and be comprised of alphanumeric characters, the period, the hyphen or the plus sign only. Please see RFC1738 for more detail."
* required by App Store Connect * see also: https://docs.microsoft.com/de-de/xamarin/ios/app-fundamentals/images-icons/app-icons
* required by App Store Connect
* required by App Store Connect * exported from the .sketch file
* not needed in assets
mattleibow
left a comment
There was a problem hiding this comment.
Looks good. Maybe we can keep the same version numbers of "1.0" so we don't have to update it for each release.
Also, I see a comment in the issue about the CFBundleIconName. And, where are the "several cases of "Invalid Image Path"" issues resolved?
Yeah, well, that is kind of optional from my side. I thought it would be better to update it to the current version now, so that it's somewhat less outdated, even if it will not be updated for every release.
I think that was fixed by the migration to the asset catalog (see 544c970), which removed the
In 4166093. |
Description of Change
This PR fixes issue #1467 by dealing with all problems that are reported when trying to upload the Samples.iOS app to App Store Connect, including:
Bugs Fixed
API Changes
None.
Behavioral Changes
None.
PR Checklist
mainat time of PR