This repository was archived by the owner on May 15, 2024. It is now read-only.
[iOS] [WebAuth] Correctly interpret iOS WebAuthenticator errors#1507
Merged
mattleibow merged 5 commits intomainfrom Nov 10, 2020
Merged
[iOS] [WebAuth] Correctly interpret iOS WebAuthenticator errors#1507mattleibow merged 5 commits intomainfrom
mattleibow merged 5 commits intomainfrom
Conversation
- Don't catch our own errors and then throw them - Correctly convert from cancellation NSErrors into .NET cancellation exceptions - Fixes #1240
#1240, but for macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
When using
ASWebAuthenticationSessionandSFAuthenticationSession, the cancellation operations are marked by iOS throwing an exception. This PR catches those errors and then converts them into cancellation exceptions.I also removed the containing try/catch block as that was actually catching the exceptions that were set in the
TaskCompletionSourceand then re-throwing them.Bugs Fixed
API Changes
None.
Behavioral Changes
iOS cancellation errors are now exposed as .NET cancellation exceptions.
PR Checklist
mainat time of PR