This repository was archived by the owner on May 15, 2024. It is now read-only.
Don't throw if iOS can't pick multiple files#1501
Merged
mattleibow merged 3 commits intomainfrom Nov 6, 2020
Merged
Conversation
jamesmontemagno
approved these changes
Nov 6, 2020
Collaborator
|
I should also probably document this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
On pre-iOS 11, the
UIDocumentPickerViewController.AllowsMultipleSelectiondid not exist.Our previous solution was to throw, but this is inconsistent with all the other platforms. If an app on android can't pick multiple files, then it still works as the multiple flag is almost optional.
Bugs Fixed
AllowsMultipleSelection#1492API Changes
None.
Behavioral Changes
On older iOS versions, the app no longer throws an exception.
PR Checklist
mainat time of PR