Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Make sure that there is always a valid Intent#1480

Merged
mattleibow merged 1 commit intomainfrom
dev/fix-1397
Nov 4, 2020
Merged

Make sure that there is always a valid Intent#1480
mattleibow merged 1 commit intomainfrom
dev/fix-1397

Conversation

@mattleibow
Copy link
Copy Markdown
Member

Description of Change

Make sure that there is always a valid Intent when the intermediate activity returns.

Bugs Fixed

API Changes

None.

Behavioral Changes

If the intent is null, then create one and not crash.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@mattleibow mattleibow added this to the 1.6.0 milestone Oct 27, 2020
@mattleibow
Copy link
Copy Markdown
Member Author

@Mrnikbobjeff Thanks for the research. I did not include the check for the resultCode in this PR as I am unsure what the side effects will be. I can do that in a new PR and after a few tests.

@Mrnikbobjeff
Copy link
Copy Markdown
Contributor

I was also unsure about the side effects. Because I could not verify the behaviour I also would use the compatible version which does not check the result code. According to the documentation this does appear to be a valid guard though :)

@mattleibow
Copy link
Copy Markdown
Member Author

There that "FirstUser" option as well. I'll have a look at this, but I suppose in the meantime the nuget can be checked by anyone with a dodgy device.

@zunjae
Copy link
Copy Markdown

zunjae commented Oct 29, 2020

@mattleibow how can we test this branch? I can't seem to figure out how to make NuGet pull this fix

@Mrnikbobjeff
Copy link
Copy Markdown
Contributor

I pushed the PR build to the preview feed so hopefully there can be a test.

Feed: https://aka.ms/xamarin-ci/index.json
Version: 1.6.0-pr.1480.1

Quoting mat from the issue linked to this pr. Simply add the link to your budget.json or if you build from within Vs you can also add the package source there

@zunjae
Copy link
Copy Markdown

zunjae commented Oct 29, 2020

@Mrnikbobjeff I have no idea what a budget.json is, a Google search doesn't help either. I've added the link as source in the Package Sources tab, however, when opening the NuGet Package Manager and searching all packages (including pre-releases), I only see "Microsoft.Azure.Mobile.Client" and "Microsoft.Azure.Mobile.Client.SQLiteStore".

Is the branch already live or do I need to wait?

@Mrnikbobjeff
Copy link
Copy Markdown
Contributor

Mrnikbobjeff commented Oct 29, 2020

Yeesh, mobile autocorrect changed nuget.json to budget.json. And @mattlebow the package is indeed not live. Linking to packageindex:

{"packages":{"Microsoft.Azure.Mobile.Client":["4.2.0-pr.552.2","4.2.0-ci.1"],"Microsoft.Azure.Mobile.Client.SQLiteStore":["4.2.0-pr.552.2","4.2.0-ci.1"]},"symbols":{}}

@zunjae
Copy link
Copy Markdown

zunjae commented Oct 29, 2020

image

@Mrnikbobjeff Yeah I've done that... Still unable to see Xamarin.Essentials

I really don't see a valid reason for having to wait over 2 days for a PR to be live

@mattleibow
Copy link
Copy Markdown
Member Author

mattleibow commented Oct 29, 2020

@zunjae @Mrnikbobjeff terribly sorry, I think I pasted the wrong URL to the feed. I was working with both and then mixed them up... I wonder what I sent to the other team 😬

The correct feed is https://aka.ms/xamarin-essentials-ci/index.json

@mattleibow mattleibow merged commit 7168da0 into main Nov 4, 2020
@mattleibow mattleibow deleted the dev/fix-1397 branch November 4, 2020 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] NullReferenceException is thrown after CapturePhotoAsync

3 participants