Skip to content

Update wxWidgets to v3.2.5.#2552

Closed
jmoraleda wants to merge 1 commit intowxWidgets:masterfrom
jmoraleda:3.2.5
Closed

Update wxWidgets to v3.2.5.#2552
jmoraleda wants to merge 1 commit intowxWidgets:masterfrom
jmoraleda:3.2.5

Conversation

@jmoraleda
Copy link
Copy Markdown
Contributor

Update wxWidgets to v3.2.5. Add support for new API MSW-only Accessibility related methods in wxWidgets. See relevant wxWidgets commit.

@swt2c
Copy link
Copy Markdown
Collaborator

swt2c commented May 17, 2024

Thanks, was going to do this myself soon. Let's see how the CI does...

@swt2c
Copy link
Copy Markdown
Collaborator

swt2c commented May 17, 2024

Actually yeah I think we probably want Dietmar's version of the accessibility stuff. So let's drop that from this one and just update to wx 3.2.5 (or I can do that).

@jmoraleda
Copy link
Copy Markdown
Contributor Author

What about we do it in two phases? This PR, does the minimal update to 3.2.5 (without the minimal windows.h stuff that I have here it won't compile on GTK or Mac). And then we can do the the other PR to actually add Accessibility support. What do you think?

@swt2c
Copy link
Copy Markdown
Collaborator

swt2c commented May 17, 2024

Can you update this to include Dietmar's changes? If not, I'll do it.

@jmoraleda
Copy link
Copy Markdown
Contributor Author

Scott, thank you for offering to help. Please, go ahead and make the changes. Either as part of this PR, or merge this PR and then immediately add Dietmars'. As you think best.

I am not comfortable enough with sip to make Dietmar's changes: I was able to make the changes here because the new functions had identical signatures to GetAccessible which was already handled in sip.

@swt2c
Copy link
Copy Markdown
Collaborator

swt2c commented May 18, 2024

You don't have to know anything about sip, just how to copy and paste. Anyway, I merged your changes with Dietmar's and pushed them (I couldn't push to your branch even though github says I should be able to edit your PR).

@jmoraleda
Copy link
Copy Markdown
Contributor Author

Thank you, Scott.

@jmoraleda jmoraleda closed this May 18, 2024
@jmoraleda jmoraleda deleted the 3.2.5 branch May 18, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants