speedmeter.py lost background color#2528
Merged
Merged
Conversation
missing typcast makes the backgraound of the speedmeter white
swt2c
reviewed
Feb 13, 2024
Contributor
Author
|
Should work too. The problem was the floating-point value and your solution
fixes it.
Scott Talbert ***@***.***> schrieb am Di., 13. Feb. 2024,
23:25:
… ***@***.**** commented on this pull request.
------------------------------
In wx/lib/agw/speedmeter.py
<#2528 (comment)>:
> @@ -840,7 +840,7 @@ def Draw(self, dc):
interface = 0
for ind in range(numsteps+1):
- currCol = (r1 + rf, g1 + gf, b1 + bf)
+ currCol = (r1 + int(rf), g1 +int(gf), b1 +int(bf))
⬇️ Suggested change
- currCol = (r1 + int(rf), g1 +int(gf), b1 +int(bf))
+ currCol = (int(r1 + rf), int(g1 + gf), int(b1 + bf))
—
Reply to this email directly, view it on GitHub
<#2528 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEEUKHZRPWDKY7YHZILD6VTYTPR4NAVCNFSM6AAAAABDHF4LUSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZZGA2DIMBWHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing typcasts make the background of the speedmeter white
This problem seems to appear since python 3.10 on windows, linux, raspian ... After this change it works. please look in the other instruments for similar mistakes, please.