Skip to content

fixed 'str' to 'wxString' converstation, when emoji is inside string#2488

Merged
swt2c merged 1 commit into
wxWidgets:masterfrom
timrid:bugfix/str-to-wxstring-with-emoji
Nov 28, 2023
Merged

fixed 'str' to 'wxString' converstation, when emoji is inside string#2488
swt2c merged 1 commit into
wxWidgets:masterfrom
timrid:bugfix/str-to-wxstring-with-emoji

Conversation

@timrid

@timrid timrid commented Nov 27, 2023

Copy link
Copy Markdown
Contributor

Fixes #2446

@swt2c

swt2c commented Nov 28, 2023

Copy link
Copy Markdown
Collaborator

Thanks for investigating and for the fix. I have a very slight worry since this use of PyUnicode_AsWideChar is only documented in the comments (it doesn't seem to be in the HTML documentation), but it seems that existing cpython code uses it, so it's probably OK.

@swt2c swt2c merged commit 20447e7 into wxWidgets:master Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'str' to 'wxString' converstation is broken, when emoji is inside string

2 participants