build.py: don't nuke PYTHONPATH#1584
build.py: don't nuke PYTHONPATH#1584deliciouslytyped wants to merge 1 commit intowxWidgets:masterfrom
Conversation
Append phoenixDir to PYTHONPATH instead of overwriting it.
|
I think I also go it backwards because python seems to load from the first found result not the last one. I need to look into this more. |
| setDevModeOptions(args) | ||
|
|
||
| os.environ['PYTHONPATH'] = phoenixDir() | ||
| os.environ['PYTHONPATH'] = os.environ['PYTHONPATH'] + ':' + phoenixDir() |
There was a problem hiding this comment.
os.pathsep should be used instead of ':'
|
|
||
| sys.path.insert(0, phoenixDir()) | ||
| os.environ['PYTHONPATH'] = phoenixDir() | ||
| os.environ['PYTHONPATH'] = os.environ['PYTHONPATH'] + ':' + phoenixDir() |
|
The |
|
Thanks! will add the changes later. |
|
@deliciouslytyped could i get you to take a look at this again? |
|
"Its not that big of a deal" - but if you want it, it'll probably be faster for you to give it a shot because I haven't touched my wxPython stuff in a bit and I'm distracted by exams. Thanks for the reminder though. |
i'll submit a PR that closes this one if i get things building with nix, good luck |
Append phoenixDir to PYTHONPATH instead of overwriting it.
Partially Fixes #1314