fix: support different kinds of close, correct client unsubscribe behaviour#1174
Merged
endigma merged 2 commits intoJun 10, 2025
Merged
Conversation
5 tasks
e997ae8 to
1215d95
Compare
1215d95 to
4752731
Compare
devsergiy
approved these changes
Jun 9, 2025
This was referenced Jun 10, 2025
endigma
pushed a commit
that referenced
this pull request
Jun 10, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0-rc.187](v2.0.0-rc.186...v2.0.0-rc.187) (2025-06-10) ### Bug Fixes * support different kinds of close, correct client unsubscribe behaviour ([#1174](#1174)) ([b6de322](b6de322)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
endigma
pushed a commit
that referenced
this pull request
Jul 2, 2025
🤖 I have created a release *beep* *boop* --- ## [1.4.0](execution/v1.3.1...execution/v1.4.0) (2025-07-02) ### Features * improve apollo gateway compatible field selection validation ([#1169](#1169)) ([8c1a063](8c1a063)) ### Bug Fixes * support different kinds of close, correct client unsubscribe behaviour ([#1174](#1174)) ([b6de322](b6de322)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Added a changelog entry for version 1.4.0, highlighting improved field selection validation and enhanced client unsubscribe handling. * **Chores** * Updated the component version to 1.4.0. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1158, I added a new path for handling server closure, but as an unintended side effect some scenarios that were previously silently failing such as complete-after-error in subscription init events became obviously broken.
This PR follows up on this by adding options for the kind of closure the caller wants, including 3 to start:
It also: