Skip to content

Commit fe09f5b

Browse files
ysmolskiysmolski
committed
fix typos
1 parent 6f15267 commit fe09f5b

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

‎v2/pkg/engine/plan/abstract_selection_rewriter.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import (
1515
var (
1616
ErrFieldHasNoSelectionSet = errors.New("unexpected error: field does not have a selection set")
1717
ErrInlineFragmentHasNoSelectionSet = errors.New("unexpected error: inline fragment does not have a selection set")
18-
ErrInlineFragmentHasNoCondition = errors.New("unexpected error: inline fragment type condition does not exists")
18+
ErrInlineFragmentHasNoCondition = errors.New("unexpected error: inline fragment type condition does not exist")
1919

2020
ErrNoUpstreamSchema = errors.New("unexpected error: upstream schema is not defined in DataSource")
2121
)
@@ -638,7 +638,7 @@ func (r *fieldSelectionRewriter) collectChangedRefs(fieldRef int, fieldRefsPaths
638638
for fieldRef, path := range fieldRefsPaths {
639639
newRefs, ok := pathsToRefs[path]
640640
if !ok {
641-
// TODO: some path actually could dissapear due to rewrite
641+
// TODO: some paths could actually disappear due to rewrite
642642
continue
643643
}
644644

‎v2/pkg/engine/plan/abstract_selection_rewriter_info.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ func (r *fieldSelectionRewriter) collectInlineFragmentInformation(
140140
typeNamesImplementingInterface: typeNamesImplementingInterface,
141141
}
142142

143-
// NOTE: We are getting type names implementing interface from the current SUBGRAPH definion
143+
// NOTE: We are getting type names implementing interface from the current SUBGRAPH definition
144144
// NOTE: at this point we ignore case when upstreamNode is not exists in the upstream schema
145145
upstreamNode, hasUpstreamNode := r.upstreamDefinition.NodeByNameStr(typeCondition)
146146
if hasUpstreamNode {
@@ -163,7 +163,7 @@ func (r *fieldSelectionRewriter) collectInlineFragmentInformation(
163163
unionMemberTypeNames: unionMemberTypeNames,
164164
}
165165

166-
// NOTE: We are getting type names of union members from the current SUBGRAPH definion
166+
// NOTE: We are getting type names of union members from the current SUBGRAPH definition
167167
// NOTE: at this point we ignore case when upstreamNode is not exists in the upstream schema
168168
upstreamNode, hasUpstreamNode := r.upstreamDefinition.NodeByNameStr(typeCondition)
169169
if hasUpstreamNode {

‎v2/pkg/engine/plan/abstract_selection_rewriter_test.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ func TestInterfaceSelectionRewriter_RewriteOperation(t *testing.T) {
221221

222222
testCases := []testCase{
223223
{
224-
name: "should flatten interfaces for grpc",
224+
name: "should flatten interfaces for gRPC",
225225
fieldName: "named",
226226
definition: definitionB,
227227
upstreamDefinition: definitionB,
@@ -254,7 +254,7 @@ func TestInterfaceSelectionRewriter_RewriteOperation(t *testing.T) {
254254
shouldRewrite: true,
255255
},
256256
{
257-
name: "should flatten union for grpc",
257+
name: "should flatten union for gRPC",
258258
fieldName: "union",
259259
definition: definitionB,
260260
upstreamDefinition: definitionB,
@@ -287,7 +287,7 @@ func TestInterfaceSelectionRewriter_RewriteOperation(t *testing.T) {
287287
shouldRewrite: true,
288288
},
289289
{
290-
name: "should not flatten interfaces for non-grpc",
290+
name: "should not flatten interfaces for non-gRPC",
291291
fieldName: "named",
292292
definition: definitionB,
293293
upstreamDefinition: definitionB,
@@ -321,7 +321,7 @@ func TestInterfaceSelectionRewriter_RewriteOperation(t *testing.T) {
321321
shouldRewrite: false,
322322
},
323323
{
324-
name: "should not flatten union for non-grpc",
324+
name: "should not flatten union for non-gRPC",
325325
fieldName: "union",
326326
definition: definitionB,
327327
upstreamDefinition: definitionB,

‎v2/pkg/engine/plan/datasource_configuration.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ type DataSourcePlanningBehavior struct {
383383
// alias: rootField
384384
// }
385385
// On dynamic data sources (GraphQL, SQL) this should be set to true,
386-
// and for static data sources (REST, static, GRPC) it should be false.
386+
// and for static data sources (REST, static, gRPC) it should be false.
387387
MergeAliasedRootNodes bool
388388

389389
// OverrideFieldPathFromAlias set to true will let the planner know

0 commit comments

Comments
 (0)