Skip to content

chore: set mcp.server.base_url as deprecated#2343

Merged
alepane21 merged 3 commits into
mainfrom
ale/eng-8517-set-mcpserverbase_url-as-deprecated
Nov 20, 2025
Merged

chore: set mcp.server.base_url as deprecated#2343
alepane21 merged 3 commits into
mainfrom
ale/eng-8517-set-mcpserverbase_url-as-deprecated

Conversation

@alepane21

@alepane21 alepane21 commented Nov 19, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Documentation
    • Marked the MCP server base_url configuration as deprecated and added a deprecation message to the public schema indicating SSE protocol support has ended.
  • Chores
    • Removed the configurable base_url option from server initialization and related configuration surface; runtime behavior remains unchanged.

✏️ Tip: You can customize this high-level summary in your review settings.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

@coderabbitai

coderabbitai Bot commented Nov 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

Removed BaseURL configuration and wiring from the MCP/GraphQL schema server and marked the MCP server base_url config schema as deprecated with a deprecation message about SSE protocol removal. No other logic additions were introduced.

Changes

Cohort / File(s) Summary
MCP Server Configuration Schema
router/pkg/config/config.schema.json		 Added deprecation metadata ("deprecated": true and "deprecationMessage") to the base_url property in the MCP server configuration schema.
Router bootstrap change
router/core/router.go		 Removed the MCP server option call that passed the configured BaseURL (mcpserver.WithBaseURL(r.mcp.Server.BaseURL)), so BaseURL is no longer provided at initialization.
MCP GraphQL schema server implementation
router/pkg/mcpserver/server.go		 Removed Options.BaseURL field, GraphQLSchemaServer.baseURL field, the WithBaseURL(baseURL string) option helper, and the assignment of baseURL in NewGraphQLSchemaServer(...), eliminating BaseURL configuration and storage in the server implementation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Heterogeneous changes: schema metadata plus code removals across initialization and server implementation.
  • Areas to focus during review:
    • Ensure no remaining call sites expect WithBaseURL or Options.BaseURL.
    • Verify initialization in router/core/router.go remains correct without the removed option.
    • Confirm there are no runtime assumptions, tests, or logging that referenced baseURL elsewhere.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: marking the MCP server's base_url configuration field as deprecated across schema and implementation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19e3c54 and c71077a.

📒 Files selected for processing (1)
  • router/pkg/mcpserver/server.go (0 hunks)
💤 Files with no reviewable changes (1)
  • router/pkg/mcpserver/server.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: build-router
  • GitHub Check: Analyze (go)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: build_push_image (nonroot)
  • GitHub Check: image_scan (nonroot)
  • GitHub Check: integration_test (./telemetry)
  • GitHub Check: integration_test (./events)
  • GitHub Check: build_push_image
  • GitHub Check: image_scan
  • GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
  • GitHub Check: build_test

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Nov 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Router-nonroot image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-fdefef05a0bcd5e98a680cecb4781c705ccbcb0e-nonroot

@github-actions

github-actions Bot commented Nov 19, 2025

Copy link
Copy Markdown

Router-nonroot image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-a46edae1a1068b9cfde7932726862ca76af89165-nonroot

StarpTech
StarpTech approved these changes Nov 19, 2025
View reviewed changes

@StarpTech StarpTech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alepane21 alepane21 merged commit df8a0e3 into main Nov 20, 2025
28 checks passed
@alepane21 alepane21 deleted the ale/eng-8517-set-mcpserverbase_url-as-deprecated branch November 20, 2025 10:51
@coderabbitai coderabbitai Bot mentioned this pull request Nov 28, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Noroth Noroth Awaiting requested review from Noroth

@devsergiy devsergiy Awaiting requested review from devsergiy

@jensneuse jensneuse Awaiting requested review from jensneuse

@endigma endigma Awaiting requested review from endigma

1 more reviewer

@StarpTech StarpTech StarpTech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alepane21 @StarpTech