Skip to content

chore(router): update Cosmo Streams ADR#2314

Merged
dkorittki merged 7 commits into
topic/streams-v1from
dominik/eng-8437-update-cosmo-streams-adr
Oct 31, 2025
Merged

chore(router): update Cosmo Streams ADR#2314
dkorittki merged 7 commits into
topic/streams-v1from
dominik/eng-8437-update-cosmo-streams-adr

Conversation

@dkorittki

@dkorittki dkorittki commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

This updates the ADR to reflect the latest changes we made on Cosmo Streams. Besides updating the existing code examples I also added two for the OnReceiveEvents and OnPublishEvents hooks.

@dkorittki dkorittki requested review from a team as code owners October 31, 2025 08:21
@dkorittki dkorittki requested review from JivusAyrus, Noroth, devsergiy and wilsonrivera and removed request for a team October 31, 2025 08:21
@coderabbitai

coderabbitai Bot commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dkorittki dkorittki changed the title Dominik/eng 8437 update cosmo streams adr chore(router): Update cosmo streams ADR Oct 31, 2025
@dkorittki dkorittki changed the title chore(router): Update cosmo streams ADR chore(router): Update Cosmo Streams ADR Oct 31, 2025
@dkorittki dkorittki requested review from alepane21 and removed request for JivusAyrus, Noroth, devsergiy and wilsonrivera October 31, 2025 08:23
@dkorittki dkorittki changed the title chore(router): Update Cosmo Streams ADR chore(router): update Cosmo Streams ADR Oct 31, 2025
alepane21
alepane21 approved these changes Oct 31, 2025
View reviewed changes
Comment thread adr/cosmo-streams-v1.md Outdated

func NewStreamEvents(evts []StreamEvent) StreamEvents

// each provider will have its own event type with custom fields

@alepane21 alepane21 Oct 31, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the comment to be more "standard":
StreamEvent is a read-only event. Every provider will have it's specific implementation with additionals fields

Comment thread adr/cosmo-streams-v1.md Outdated
Comment thread adr/cosmo-streams-v1.md Outdated
Comment thread adr/cosmo-streams-v1.md Outdated
@dkorittki dkorittki merged commit a4df549 into topic/streams-v1 Oct 31, 2025
4 checks passed
@dkorittki dkorittki deleted the dominik/eng-8437-update-cosmo-streams-adr branch October 31, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alepane21 alepane21 alepane21 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkorittki @alepane21