Add section for testing negative case

wspurgin · wspurgin · commit 603b9018b3ae · 2023-08-01T11:04:12.000-05:00
Update link for warning message
diff --git a/README.md b/README.md
@@ -102,7 +102,6 @@ AwesomeJob.set(queue: "high").perform_async("Very Awesome!")
 expect(AwesomeJob).to have_enqueued_sidekiq_job("Very Awesome!").on("high")
 ```
 
-
 #### Testing ActiveMailer jobs
 
 ```ruby
@@ -118,6 +117,25 @@ expect(Sidekiq::Worker).to have_enqueued_sidekiq_job(
 )
 ```
 
+#### Testing a job is _not_ enqueued
+
+The negative case for `have_enqueued_sidekiq_job` is provided, but it's
+important to remember that `have_enqueued_sidekiq_job` is an expectation of
+specific _arguments_. That means, unless you tell the matcher that _no_ jobs
+with _any_ arguments should be enqueued, you'll get the wrong result:
+
+```ruby
+# failing case
+AwesomeJob.perform_async "Actually not awesome"
+
+### BAD - saying there shouldn't be a job enqueued _without_ args
+expect(AwesomeJob).not_to have_enqueued_sidekiq_job
+# => passes! 😱
+
+### Good
+expect(AwesomeJob).not_to have_enqueued_sidekiq_job(any_args)
+```
+
 ### be_processed_in
 *Describes the queue that a job should be processed in*
 ```ruby
diff --git a/lib/rspec/sidekiq/sidekiq.rb b/lib/rspec/sidekiq/sidekiq.rb
@@ -14,7 +14,7 @@ def configuration
 
 RSpec.configure do |config|
   config.before(:suite) do
-    message = '[rspec-sidekiq] WARNING! Sidekiq will *NOT* process jobs in this environment. See https://github.com/philostler/rspec-sidekiq/wiki/FAQ-&-Troubleshooting'
+    message = '[rspec-sidekiq] WARNING! Sidekiq will *NOT* process jobs in this environment. See https://github.com/wspurgin/rspec-sidekiq/wiki/FAQ-&-Troubleshooting'
     message = "\e[33m#{message}\e[0m" if RSpec::Sidekiq.configuration.enable_terminal_colours
     puts message if RSpec::Sidekiq.configuration.warn_when_jobs_not_processed_by_sidekiq
   end
