Fix dataviews bundle#3
Merged
bph merged 4 commits intowptrainingteam:mainfrom Dec 5, 2024
oandregal:fix/dataviews-bundle
Merged
Fix dataviews bundle#3bph merged 4 commits intowptrainingteam:mainfrom oandregal:fix/dataviews-bundle
bph merged 4 commits intowptrainingteam:mainfrom
oandregal:fix/dataviews-bundle
Conversation
This was referenced Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
What
This PR uses the approach implemented at WordPress/gutenberg#66825 to bundle every dependency required by DataViews.
Why
To prevent conflicts from having different versions of the underlying libraries (e.g.:
@wordpress/components).How
nextversions of@wordpress/scriptsand@wordpress/dataviews. The patch hasn't been released to the stable version yet.npm install --save @wordpress/dataviews@next, which today results in this version 72b3c61npm install --save-dev @wordpress/scripts@next, which today results in this version e9d7fcb@wordpress/dataviews/wp. See 18fcb6eHow to test
Use WordPress 6.6 or WordPress 6.7, with and without the Gutenberg plugin active. Make sure the plugin still works.