Fix(a11y): Prevent output of hidden site branding (#758)#892
Merged
robruiz merged 1 commit intowprig:developfrom Aug 28, 2025
Merged
Conversation
Updates branding.php to respect the 'display_header_text' Customizer setting, removing redundant links and screen reader chatter. Resolves wprig#758.
Contributor
Author
|
@robruiz , please review this and merge it. |
robruiz
approved these changes
Aug 28, 2025
Contributor
robruiz
left a comment
There was a problem hiding this comment.
This looks great! Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #758.
This pull request fixes an accessibility issue where the site title and description were visually hidden but still accessible to screen readers and keyboard navigation. This caused redundant links, loss of keyboard focus, and unnecessary screen reader chatter.
The fix updates template-parts/header/branding.php to wrap the output of the site title and description in a conditional check for the display_header_text Customizer setting. If a user has unchecked "Display Site Title and Tagline," the corresponding HTML is no longer rendered at all, providing a cleaner and more accessible user experience.