Update/prevent corruption for filesToCopy files while bundling#882
Merged
robruiz merged 2 commits intowprig:developfrom Aug 31, 2025
Merged
Conversation
Contributor
|
@skywardpro - I already created a fix for this and it is in the develop branch. If could test that branch out and ensure the problem no longer exists on that branch, I would deeply appreciate it. Thank you. |
Contributor
Author
Hey! We tested and mostly it works, but when it copies videos - they are still broken Tested with following formats: |
robruiz
approved these changes
Aug 31, 2025
Contributor
robruiz
left a comment
There was a problem hiding this comment.
Looks like an interesting solve. Going to merge into develop and test there. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After bundling some files become corrupted.
During the investigation it was found that:
The issue was found and described here: Corrupted files in bundled theme. #879
Addresses issue #
My solution is to replace the Gulp stream logic in prodPrep.js with the manual Node.js fs stream logic. This bypasses the problematic Gulp handling specifically for the files listed in filesToCopy.
List of changes
Checklist: