Merged
Conversation
Add stream wrapper to inject declare(ticks=1) in all loaded php files Add check to also disable OPCache if found Add plugin archive
av3nger
approved these changes
Oct 27, 2020
|
Didn't work, my wordpress still prints this:
So, I can't start the scan. |
|
@z3nth10n , do you have any errors in the browser console? |
|
For me it completely breaks the site and I get "ERR_CONNECTION_RESET". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
debug_backtraceworks. From my investigations I found that this is not the problem. The actual issue is withdeclare(ticks=1); when you do this it is no longer activated in all included files from now on: https://www.php.net/manual/en/migration70.incompatible.php#migration70.incompatible.other.declare-ticks .The solution to this is to inject
declare(ticks=1)at the beginning of each new file included.P.S. I added the archive to the commit so I can point people to use it until you merge this pull request and update the plugin in WordPress repo.