Respect id when getting entry type id#227
Merged
rasmusbe merged 1 commit intowp-papi:masterfrom Apr 24, 2017
rasmusbe:respect-id
Merged
Respect id when getting entry type id#227rasmusbe merged 1 commit intowp-papi:masterfrom rasmusbe:respect-id
rasmusbe merged 1 commit intowp-papi:masterfrom
rasmusbe:respect-id
Conversation
Also fixes some tests that didn't respect the ID / post type
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
===========================================
- Coverage 90.62% 90.1% -0.52%
Complexity 1912 1912
===========================================
Files 95 96 +1
Lines 5877 5983 +106
===========================================
+ Hits 5326 5391 +65
- Misses 551 592 +41
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes papi_get_field for specific IDs on certain pages (term archive pages for example)
Also fixes some tests that didn't respect the ID / post type.
Checklist