Optimize papi_is_empty check for arrays#191
Merged
frozzare merged 1 commit intowp-papi:masterfrom Sep 10, 2016
rasmusbe:optimize-empty-check
Merged
Optimize papi_is_empty check for arrays#191frozzare merged 1 commit intowp-papi:masterfrom rasmusbe:optimize-empty-check
frozzare merged 1 commit intowp-papi:masterfrom
rasmusbe:optimize-empty-check
Conversation
An array is not empty if one of the values is not empty, therfore we should not loop thru the whole array if not necessary.
Current coverage is 94.93% (diff: 100%)@@ master #191 diff @@
==========================================
Files 82 82
Lines 5213 5215 +2
Methods 481 481
Messages 0 0
Branches 0 0
==========================================
+ Hits 4949 4951 +2
Misses 264 264
Partials 0 0
|
Member
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An array is not empty if one of the values is not empty, therefore we should not loop thru the whole array if not necessary.
This change makes a huge speed improvement for papi_is_empty, in my tests from an improvement of 96%.