Make sure oembed field is also formatted when part of a flexible_content field#126
Merged
jasonbahl merged 1 commit intowp-graphql:mainfrom Nov 21, 2023
Merged
Make sure oembed field is also formatted when part of a flexible_content field#126jasonbahl merged 1 commit intowp-graphql:mainfrom
jasonbahl merged 1 commit intowp-graphql:mainfrom
Conversation
Contributor
|
@kpoelhekke thanks! I'm running the tests now to confirm. Unfortunately they will fail when a PR is opened from outside the repo because some repo secrets are needed to test against ACF PRO, but I'm checking now |
jasonbahl
approved these changes
Nov 21, 2023
Contributor
|
@kpoelhekke I've confirmed existing tests pass. We don't have a great setup for testing individual fields as sub-fields of repeaters or flex fields yet, so I'm going to open up an issue (see: #127) to better support testing fields within repeaters/flex fields so we can stay on top of these cases going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This change makes sure that fields that are part of a
flexible_contentfield are also formatted. Currently this is not the case for theoembedfield for example.Does this close any currently open issues?
No, but relates to #106
Any relevant logs, error output, GraphiQL screenshots, etc?
Before
After
Any other comments?
This is a breaking change.