fix: restore whitespace rules for PHPCBF#291
Merged
josephfusco merged 4 commits intowp-graphql:mainfrom Aug 29, 2024
Merged
Conversation
Collaborator
|
@missionmike looks like tests are failing, but not related to your PR. I opened another PR #292 to address the failing tests (needed to update to use |
Collaborator
|
@missionmike I merged the other PR that fixed the docker tests and just merged the changes into this PR so tests should run now |
jasonbahl
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores some rules that auto-format trailing whitespace and newlines in PHPCBF. I copied the code from: AxeWP/WPGraphQL-Coding-Standards@23dbbaf (thanks @justlevine)
Before
Example from before these rules are reintroduced; the formatter ignores these spacing issues:
After
With the rules reintroduced, the file is formatted as expected, with extraneous whitespace removed:
Note
I attempted to try installing WPGraphQL CS from here using
composer require --dev axepress/wp-graphql-csto see if we could use a single source of rulesets, but I ran into this error:I'm not sure if it's worth pursuing to use the single code rule source, or if it's a rabbit hole I shouldn't venture down right now. Open to ideas. Thanks!