Adds Option to define if a cookie should be set on login.#85
Merged
Adds Option to define if a cookie should be set on login.#85
Conversation
Collaborator
Author
|
Maybe this would rather make sense as a boolean filter in the registration/login mutation? |
renatonascalves
suggested changes
Mar 10, 2020
renatonascalves
left a comment
There was a problem hiding this comment.
PHPDoc: correct inline comments.
Co-Authored-By: Renato Alves <renato@alley.co>
Co-Authored-By: Renato Alves <renato@alley.co>
victors1681
approved these changes
Aug 18, 2021
victors1681
left a comment
There was a problem hiding this comment.
I did that change before noticed this PR.. looking good.
jasonbahl
reviewed
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the idea is to give an option to enable this behaviour.
One option would be to be able to define something in wp-config.php like so:
Then the
authenticate_userfunction would usewp_signonwith cookies set to true instead ofwp_authenticate.I for example need the cookie to be set, so I can use it for the protected Downloads in WooCommerce.
Could be related to this issue: #73
We could use this approach to also set the RefreshToken as a HttpOnly cookie. Then you could decide to use the JWT in a HttpOnly environment if you need/want to, or still just take it from the response and handle it yourself.
Open for suggestions on how to approach this though. This one works fine for me so far.