fix(response headers): replace single header instead of overwriting them all#118
Merged
jasonbahl merged 1 commit intowp-graphql:developfrom Oct 25, 2022
Merged
fix(response headers): replace single header instead of overwriting them all#118jasonbahl merged 1 commit intowp-graphql:developfrom
jasonbahl merged 1 commit intowp-graphql:developfrom
Conversation
updated to call the 'header' instead of 'set_headers' method when writing response headers to avoid overwriting all the headers such as X-WP-Total and X-WP-TotalPages which are necessary for different plugins and pieces of Wordpress to work properly
This was referenced Nov 4, 2020
|
Hi @jasonbahl this fixes some issues for me and from what I see for other folks, do you think you can merge it or do you see any side effects? |
|
We have the same issues this plugin is breaking some of our REST API apps |
|
Would love to see this merged, currently Woocommerce Analytics is partly broken because of this. 👀 |
Contributor
Author
|
Coming up on the 2 year anniversary of when I opened this PR — not quite sure how I'll celebrate yet. I'm pretty low key, but it never hurts to go all out every once in a while. |
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated to call the 'header' instead of 'set_headers' method when writing response headers to avoid
overwriting all the headers such as X-WP-Total and X-WP-TotalPages which are necessary for different
plugins and pieces of Wordpress to work properly