What does this implement/fix? Explain your changes.

WP_Query applies default ordering by title when the "s" arg is passed to it, which was causing funky issues with WPGraphQL Cursor Pagination.

This sets the search_orderby_title to false, and defaults to orderby date. Custom orderby options can be passed to the connection as well.

Does this close any currently open issues?

#897

Any relevant logs, error output, GraphiQL screenshots, etc?

To test, I created 4 posts with the word "floof" as the content.

In the admin, you can see a search for "floof" shows posts: `Four, Three, Two, One"

Query the last 2

Here, I query for the last: 2 items, and as expected, we get Posts Two and One.

Query

query GET_POSTS($first: Int, $last: Int, $after: String, $before: String, $where: RootQueryToPostConnectionWhereArgs) {
  posts(last: $last, before: $before, first: $first, after: $after, where: $where) {
    pageInfo {
      hasPreviousPage
      hasNextPage
      startCursor
      endCursor
    }
    edges {
      cursor
      node {
        id
        date
        title
      }
    }
  }
}

Variables

{
  "last": 2,
  "before": "YXJyYXljb25uZWN0aW9uOjEzOTc=",
  "where": {
    "search": "floof"
  }
}

Screenshot of results

Query with before cursor

Now, if we execute the same query, but use the startCursor from the previous query results as the value for the before input we get items Four and Three:

Variables

{
  "last": 2,
  "before": "YXJyYXljb25uZWN0aW9uOjEzOTc=",
  "where": {
    "search": "floof"
  }
}

Screenshot of paginated query

Any other comments

Tests are included for forward and backward pagination using the {where: { search: ""} } argument

Where has this been tested?

Operating System: Mac OSX 10.14.5
WordPress Version: WordPress v5.2.2