chore: clean up and add comments to NodeResolver::resolve_uri() conditional logic.#2656
Merged
jasonbahl merged 1 commit intowp-graphql:developfrom Dec 7, 2022
Conversation
|
Code Climate has analyzed commit 2f99e42 and detected 0 issues on this pull request. View more on Code Climate. |
jasonbahl
approved these changes
Dec 7, 2022
Merged
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR cleans up
NodeResolver::resolve_uri()to make it more readable and maintainable.More specifically, it replaces the use of
elseif()with a regularif()when the previous conditional returns early, adding a comment before each one explaining the case trying to be handled.Supersedes (partially): #2342
Note: No method logic has been changed by this PR.
This PR is intentionally limited in scope, to allow for additional incremental PRs with smaller changesets (and possibilities for regressions), since
NodeResolveris currently one of the most fragile classes currently in the codebase.Does this close any currently open issues?
Part of #2366
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
…
Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + php 8.0.19)
WordPress Version: 6.1.1